This repository has been archived by the owner on Dec 19, 2019. It is now read-only.
Customer group_id deprecation #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…del of the GraphQL to only return null value.
akamuraasai
commented
Sep 20, 2019
| @@ -101,7 +101,8 @@ public function execute(CustomerInterface $customer): array | |||
| } | |||
| } | |||
| $customerData = array_merge($customerData, $customAttributes); | |||
|
|
|||
| //Field is deprecated and should not be exposed on storefront. | |||
| $customerData['group_id'] = null; | |||
There was a problem hiding this comment.
I see, nice to know the correct file to change in cases like this.
Thank you, @lenaorobei.
lenaorobei
approved these changes
Sep 20, 2019
|
Hi @lenaorobei, thank you for the review. |
|
@akamuraasai thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository. |
magento-engcom-team
pushed a commit
that referenced
this pull request
Sep 25, 2019
|
Hi @akamuraasai, thank you for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Added a deprecated anotation to the graphql schema and changed the model of the GraphQL to only return null value.
Fixed Issues (if relevant)